Router를 정의했습니다. #17
Merged
Router를 정의했습니다. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-barry
reviewed
Jul 22, 2024
Comment on lines
52
to
68
| let baseNetworkService = BaseNetworkService() | ||
| let recipeFetchService = RecipeFetchServiceImpl(networkService: baseNetworkService) | ||
| let feedListRepository = FeedListRepositoryImpl(networkService: recipeFetchService) | ||
| let searchFeedRepository = SearchFeedRepositoryImpl(networkService: recipeFetchService) | ||
| let fetchFeedListUseCase = FetchFeedListUseCaseImpl(repository: feedListRepository) | ||
| let searchFeedListUseCase = SearchFeedListUseCaseImpl(repository: searchFeedRepository) | ||
| let recipeListInteractor = RecipeListInteractorImpl( | ||
| fetchFeedListUseCase: fetchFeedListUseCase, | ||
| searchFeedListUseCase: searchFeedListUseCase | ||
| ) | ||
| let recipeListRouter = RecipeListRouterImpl(router: self) | ||
| let recipeListVC = RecipeListViewController( | ||
| interactor: recipeListInteractor, | ||
| router: recipeListRouter | ||
| ) | ||
| recipeListInteractor.delegate = recipeListVC | ||
| return recipeListVC |
There was a problem hiding this comment.
Suggested change
| let baseNetworkService = BaseNetworkService() | |
| let recipeFetchService = RecipeFetchServiceImpl(networkService: baseNetworkService) | |
| let feedListRepository = FeedListRepositoryImpl(networkService: recipeFetchService) | |
| let searchFeedRepository = SearchFeedRepositoryImpl(networkService: recipeFetchService) | |
| let fetchFeedListUseCase = FetchFeedListUseCaseImpl(repository: feedListRepository) | |
| let searchFeedListUseCase = SearchFeedListUseCaseImpl(repository: searchFeedRepository) | |
| let recipeListInteractor = RecipeListInteractorImpl( | |
| fetchFeedListUseCase: fetchFeedListUseCase, | |
| searchFeedListUseCase: searchFeedListUseCase | |
| ) | |
| let recipeListRouter = RecipeListRouterImpl(router: self) | |
| let recipeListVC = RecipeListViewController( | |
| interactor: recipeListInteractor, | |
| router: recipeListRouter | |
| ) | |
| recipeListInteractor.delegate = recipeListVC | |
| return recipeListVC | |
| let recipeListInteractor = RecipeListInteractorImpl( | |
| fetchFeedListUseCase: FetchFeedListUseCaseImpl( | |
| repository: FeedListRepositoryImpl( | |
| networkService: RecipeFetchServiceImpl( | |
| networkService: BaseNetworkService() | |
| ) | |
| ) | |
| ), | |
| searchFeedListUseCase: SearchFeedListUseCaseImpl( | |
| repository: SearchFeedRepositoryImpl( | |
| networkService: RecipeFetchServiceImpl( | |
| networkService: BaseNetworkService() | |
| ) | |
| ) | |
| ) | |
| ) | |
| let recipeListRouter = RecipeListRouterImpl(router: self) | |
| let recipeListVC = RecipeListViewController( | |
| interactor: recipeListInteractor, | |
| router: recipeListRouter | |
| ) | |
| recipeListInteractor.delegate = recipeListVC | |
| return recipeListVC |
f-lab-barry
reviewed
Jul 22, 2024
| } | ||
|
|
||
| func navigateToRecipeDetail(from viewController: UIViewController, recipeID: Int) { | ||
| let detailVC = router.createRecipeDetailDependencies(recipeID: recipeID) |
There was a problem hiding this comment.
createRecipeDetailDependencies 레시피 디테일의 디펜던시를 만든다는 함수인데 VC가 리턴값인게 어색해요.
makeRecipeDetailViewController 정도로 해도 괜찮지 않을까요?
f-lab-barry
reviewed
Jul 22, 2024
f-lab-barry
approved these changes
Jul 23, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
화면 이동, 의존성 주입을 다른 곳에서 관리하기 위해 라우터를 도입했습니다.