Usecase,Entities,FeedListRepository,FirebaseRemoteDataSource를 생성했습니다. #2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // | ||
| // FeedListRepository.swift | ||
| // HomeCafeRecipes | ||
| // | ||
| // Created by 김건호 on 5/30/24. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| protocol FeedListRepository { | ||
| func fetchFeedItems(completion: @escaping (Result<[FeedItem], Error>) -> Void) | ||
| func searchFeedItems(title: String, completion: @escaping (Result<[FeedItem], Error>) -> Void) | ||
| } | ||
| class FeedListRepositoryImpl: FeedListRepository { | ||
| private let remoteDataSource: FirebaseRemoteDataSource | ||
|
|
||
| init(remoteDataSource: FirebaseRemoteDataSource) { | ||
| self.remoteDataSource = remoteDataSource | ||
| } | ||
|
|
||
| func fetchFeedItems(completion: @escaping (Result<[FeedItem], Error>) -> Void) { | ||
| remoteDataSource.fetchFeedItems(completion: completion) | ||
| } | ||
|
|
||
| func searchFeedItems(title : String, completion: @escaping (Result<[FeedItem], Error>) -> Void){ | ||
| remoteDataSource.searchFeedItems(title: title, completion: completion) | ||
| } | ||
|
|
||
|
|
||
|
|
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| // | ||
| // FirebaseRemoteDataSource.swift | ||
| // HomeCafeRecipes | ||
| // | ||
| // Created by 김건호 on 5/30/24. | ||
| // | ||
|
|
||
| import FirebaseFirestore | ||
|
|
||
| class FirebaseRemoteDataSource { | ||
| private let db = Firestore.firestore() | ||
|
|
||
|
|
||
| func fetchFeedItems(completion: @escaping (Result<[FeedItem], Error>) -> Void) { | ||
| db.collection("feedItems").getDocuments { (querySnapshot, error) in | ||
| if let error = error { | ||
| completion(.failure(error)) | ||
| return | ||
| } | ||
| guard let documents = querySnapshot?.documents else { | ||
| completion(.success([])) | ||
|
There was a problem hiding this comment. 성공은 했지만 빈배열일 경우를 생각해서 넣었습니다! |
||
| return | ||
| } | ||
| let feedItems = documents.compactMap { doc -> FeedItem? in | ||
| let data = doc.data() | ||
| guard | ||
| let title = data["title"] as? String, | ||
| let imageURL = data["imageURL"] as? [String] else { | ||
|
There was a problem hiding this comment. 배열이 반환되는 거면 imageURLs 와 같이 복수형으로 네이밍하는게 좋을 것 같아요 |
||
| return nil | ||
| } | ||
| return FeedItem(id: doc.documentID, title: title, imageURL: imageURL) | ||
|
There was a problem hiding this comment. 위 document는 파이어 베이스에서 제공하는 문서 자체의 ID를 선언했습니다. 하지만 해당 데이터의 id를 넣어야 할거 같아 수정하겠습니다! |
||
| } | ||
| completion(.success(feedItems)) | ||
| } | ||
| } | ||
|
|
||
| func searchFeedItems(title: String, completion: @escaping (Result<[FeedItem], Error>) -> Void) { | ||
| db.collection("feedItems").getDocuments { (querySnapshot, error) in | ||
| if let error = error { | ||
| completion(.failure(error)) | ||
| return | ||
| } | ||
| guard let documents = querySnapshot?.documents else { | ||
| completion(.success([])) | ||
| return | ||
| } | ||
| let feedItems = documents.compactMap { doc -> FeedItem? in | ||
| let data = doc.data() | ||
| guard | ||
| let title = data["title"] as? String, | ||
| let imageURL = data["imageURL"] as? [String], | ||
| title.contains(title) else { | ||
| return nil | ||
| } | ||
| return FeedItem(id: doc.documentID, title: title, imageURL: imageURL) | ||
| } | ||
| completion(.success(feedItems)) | ||
| } | ||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,12 @@ | ||||||
| // | ||||||
| // FeedModel.swift | ||||||
| // HomeCafeRecipes | ||||||
| // | ||||||
| // Created by 김건호 on 5/16/24. | ||||||
| // | ||||||
|
|
||||||
| struct FeedItem { | ||||||
| let id: String | ||||||
| let title : String | ||||||
| let imageURL : [String] | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| } | ||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| // | ||
| // fetchFeedListUsecase.swift | ||
| // HomeCafeRecipes | ||
| // | ||
| // Created by 김건호 on 5/30/24. | ||
| // | ||
|
|
||
|
|
||
| protocol FetchFeedListUseCase { | ||
| func execute(completion: @escaping (Result<[FeedItem], Error>) -> Void) | ||
| } | ||
|
|
||
| class DefaultFetchFeedListUseCase: FetchFeedListUseCase { | ||
| private let repository: FeedListRepository | ||
|
|
||
| init(repository: FeedListRepository) { | ||
| self.repository = repository | ||
| } | ||
|
|
||
| func execute(completion: @escaping (Result<[FeedItem], Error>) -> Void) { | ||
|
There was a problem hiding this comment. FeedItem이 아닌 새로 정의한 도메인 Recipe로 받도록 변경해야할 것 같아요~ |
||
| repository.fetchFeedItems { result in | ||
| completion(result) | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| // | ||
| // SearchFeedListusecase.swift | ||
| // HomeCafeRecipes | ||
| // | ||
| // Created by 김건호 on 5/30/24. | ||
| // | ||
|
|
||
|
|
||
| protocol SearchFeedListUseCase { | ||
| func execute(title: String, completion: @escaping (Result<[FeedItem], Error>) -> Void) | ||
|
There was a problem hiding this comment. UseCase에서도 return 없이 Result 타입 completion 으로 처리하는 이유가 있을까요? There was a problem hiding this comment. Usecase에서도 FeedRlistepository에서 데이터를 가지고 받으면서 비동기 작업이 필요할거라 생각해서 completion으로 처리하였습니다! There was a problem hiding this comment.
|
||
| } | ||
|
|
||
| class DefaultSearchFeedListUseCase: SearchFeedListUseCase { | ||
| private let repository: FeedListRepository | ||
|
|
||
| init(repository: FeedListRepository) { | ||
| self.repository = repository | ||
| } | ||
|
|
||
| func execute(title: String, completion: @escaping (Result<[FeedItem], Error>) -> Void) { | ||
| repository.searchFeedItems(title: title) { result in | ||
| completion(result) | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,12 @@ | ||||||
| // | ||||||
| // FeedListViewcontroller.swift | ||||||
| // HomeCafeRecipes | ||||||
| // | ||||||
| // Created by 김건호 on 5/30/24. | ||||||
| // | ||||||
|
|
||||||
| import UIKit | ||||||
|
|
||||||
| class FeedListViewController : UIViewController { | ||||||
|
There was a problem hiding this comment. final이 붙어도 좋을까요? (: 옆에 띄어쓰기도 신경써주세요~)
Suggested change
|
||||||
|
|
||||||
| } | ||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
개행 부탁드리구요, implement 클래스는 final로 선언하는게 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
23aebe4 수정했습니다!