-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
피드리스트를 받기 위한 UseCase, Entities,Repository를 정의했습니다. #4
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a99e1b0
Feat: Recipe,RecipeType 엔티티 정의
GeonH0 52c981f
Feat: FetchFeedListUseCase,SearchFeedListUseCase 정의
GeonH0 5fcb880
Feat: FeedListRepository,SearchFeedListRepository 정의
GeonH0 e9d4af2
Feat: RecipeDTO 정의
GeonH0 56c5ae6
Fix: 이미지DTO 분리, 레시피DTO prefix제거 id ID로 변경, type 기본값 coffee로 변경
GeonH0 8afc27b
Fix: RecipesResponseDTO 분리
GeonH0 d86703c
Fix: ResponseDTO로 네이밍 변경, DTO 폴더로 이동
GeonH0 628e0b7
Fix: img를 Image 줄임말 변경, recipeImageID로 네이밍 변경, ID를 id로 변경
GeonH0 a7e58be
Fix: Observable에서 단일 이벤트작업에 더 적합한 Single로 변경
GeonH0 bf60bc6
Fix: isLiked를 hasBeenLiked로 좀 더 명확히 네이밍 변경
GeonH0 84df58b
Fix: ResponseDTO를 NetworkResponseDTO로 네이밍 변경
GeonH0 506be99
Fix: RecipeImageDTO에 CodingKeys추가
GeonH0 8acf4c6
Fix: pagination을 위해 DTO구조를 변경
GeonH0 66312f1
Fix: pagination적용으로 FeedListRepository,SearchFeedListRepository 수정
GeonH0 e9763e8
Fix: pagination을 위해 FetchFeedListUseCase,SearchFeedListUseCase수정
GeonH0 b7981cc
Fix: hasBeenLiked를 isLikedByCurrentUser로 네이밍 변경
GeonH0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
HomeCafeRecipes/HomeCafeRecipes/Domain/Entities/Recipe.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// | ||
// Recipe.swift | ||
// HomeCafeRecipes | ||
// | ||
// Created by 김건호 on 6/9/24. | ||
// | ||
|
||
import Foundation | ||
|
||
struct Recipe { | ||
let id: Int | ||
let type: RecipeType | ||
let name: String | ||
let description: String | ||
let writer: User | ||
let imageUrls: [String] | ||
let isLiked: Bool | ||
let likeCount: Int | ||
let createdAt: Date | ||
} |
13 changes: 13 additions & 0 deletions
13
HomeCafeRecipes/HomeCafeRecipes/Domain/Entities/RecipeType.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
// | ||
// RecipeType.swift | ||
// HomeCafeRecipes | ||
// | ||
// Created by 김건호 on 6/9/24. | ||
// | ||
|
||
|
||
|
||
enum RecipeType: String { | ||
case coffee | ||
case dessert | ||
Comment on lines
+11
to
+12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 외에는 더 없나요? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 넵 일단은 커피와 디저트만 생각하고 있습니다! |
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likeCount가 없을 땐 0으로 가져가는건가요? nullable한 값을 가지지 않는건지 궁금해요. (likeCount 외에 다른 값들도 전부 required네요)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 likeCount가 없을때는 0으로 가져갑니다!