Fix: static을 제거하여 전역 접근 제거 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
GeonH0
commented
Jun 18, 2024
GeonH0
commented
- Mapper는 특정뷰에 종속적으로 될거 같아 전역적으로 접근하는건 불필요 할거 같아 static을 제거 하여 전역 접근을 제거 하였습니다.
f-lab-barry
reviewed
Jun 18, 2024
| @@ -31,6 +31,7 @@ class RecipeListViewModel: InputRecipeListViewModel, OutputRecipeListViewModel { | |||
| private let disposeBag = DisposeBag() | |||
| private let fetchFeedListUseCase: FetchFeedListUseCase | |||
| private let searchFeedListUseCase: SearchFeedListUseCase | |||
| private let mapper = RecipeMapper() | |||
There was a problem hiding this comment.
recipeListMapper로 더 명확한 네이밍을 가지면 좋을 것 같은데 어떻게 생각하시나요?
There was a problem hiding this comment.
좋아요! RecipeMapper 요 객체도 같이 변경되었으면 해요~
아무래도 레시피 서비스다 보니 Recipe로 시작하는 Mapper가 더 생길 것 같아서 명확히 하는게 좋을 것 같아요 😄
There was a problem hiding this comment.
b5669b5
RecipeFetchMapper로 네이밍 변경했습니다!
GeonH0
force-pushed
the
feature/feedList
branch
2 times, most recently
from
302230b to
cdc8dfa
Compare
|
Mapper는 Presentation Layer에 속하기 때문에 Fetch 같은 로직을 담는 네이밍 보다는 UI에 가까운 네이밍을 선택하는 게 어때요? |
|
f-lab-barry
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.