update: Updated Order totalCost methods #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed updateTotalCost() method - added Voucher entity - added setters to Food and Order - updated NoArgsConstructor to Public - updated calculateTotalCost() method - updated Food tests
koreanMike513
force-pushed
the
update/update-order-totalCostMethods
branch
from
27715dd to
b89c5a3
Compare
f-lab-troy
approved these changes
Dec 29, 2024
| private BigDecimal percentages; | ||
|
|
||
| public BigDecimal apply(BigDecimal totalCost) { | ||
| BigDecimal afterDiscounts = BigDecimal.valueOf(1).subtract(percentages); |
There was a problem hiding this comment.
percentages가 보통 생각하게 되는 45%인지 아니면 rate으로 변환된 0.45인지 로직을 읽어서 파악하기 전까지 명확하지 않습니다.
Multiply후 생길수 있는 decimal place에 대한 rounding logic도 추가 후 테스트 케이스를 넣을 수 있으면 좋습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
우선 말씀하신 대로 인터페이스에 노출된 메서드를 고려했을 때 애매했던 updateTotalCost()를 제거했습니다.
그 후 calculateTotalCost()는 로직을 변경한 후 남겨놓았는데
또 말씀하신 대로 NoArgsConstructor 와 Setter 를 Food 와 Order 에 한해서 일단 풀어두었습니다.
위의 변경 사항으로 인한 Food Test도 변경하였으며 통과하는 것을 확인하였습니다.