update: Updated basic domains #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
koreanMike513
commented
Dec 23, 2024
koreanMike513
commented
- import 문 수정 후
- 조금 더 필요한 필드나 메서드에 한해서 entity class에 추가 했습니다.
- added more fields and methods to domain classes - fixed import statements (from * to individual import)
f-lab-troy
reviewed
Dec 24, 2024
| return food; | ||
| } | ||
|
|
||
| public BigDecimal calculateCost(int quantity) { | ||
| return BigDecimal.valueOf((long) price.intValue() * quantity); |
There was a problem hiding this comment.
price.intValue()가 의도하신게 맞는지 확인 부탁드립니다.
There was a problem hiding this comment.
찾아보니 BigDecimal 에 multiply() 메서드가 있는것을 확인하였습니다 수정하겠습니다.
- applied multiply() method instead type manual castings
koreanMike513
added
the
partially_resolved (requires a another review)
f-lab-troy
approved these changes
Dec 26, 2024
f-lab-troy
reviewed
Dec 26, 2024
| @Enumerated(EnumType.STRING) | ||
| private OrderStatus status; | ||
|
|
||
| @OneToOne(fetch = LAZY) | ||
| @JoinColumn(name = "payment_id") | ||
| private Payment payment; | ||
|
|
||
| public void updateTotalCost(BigDecimal totalCost) { |
There was a problem hiding this comment.
totalCost, updateTotalCost, calculateTotalCost 중 필요한 것만 노출 고려
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.