[#37] 사용자 온/오프라인 상태 설정 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
f-lab-moony
approved these changes
Feb 14, 2024
| .requestMatchers(new MvcRequestMatcher.Builder(introspector).pattern(HttpMethod.GET, "/rank/**")).permitAll() | ||
| .requestMatchers(new MvcRequestMatcher.Builder(introspector).pattern(HttpMethod.GET, "/diaries/**")).permitAll() | ||
| .requestMatchers(new AntPathRequestMatcher("/login")).permitAll() | ||
| .requestMatchers(new AntPathRequestMatcher("/members", "POST")).permitAll() |
There was a problem hiding this comment.
메서드 타입같은거 문자열로 다루게 되면 실수 할 여지가 생겨서 원래처럼 enum 값을 받을 수 있게 메서드를 하나 제공하는건 어떨까요 ?
| Double longitude = Optional.ofNullable(request.getParameter("longitude")) | ||
| .map(Double::parseDouble).orElse(null); | ||
| memberService.setOnline(memberId, latitude, longitude); | ||
| response.setStatus(200); |
There was a problem hiding this comment.
200도 HttpStatus 사용하면 좋을 것 같아요 ~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memberService.setOnline(),memberService.setoffline()추가online:member, value=�멤버아이디가 저장됨.member:pos, value=멤버아이디가 redis geo operation으로 저장됨그 외 변경점
feed저장 -> graphicContent에 feed_id 설정해서 저장이렇게 하면 되는데feed저장 -> graphicContent에 feed_id를 null로 설정하고 저장 -> graphicContent의 feed_id를 업데이트이런식으로 동작함. 그래서 notnull constraints때문에 에러.