메서드의 파라미터 타입을 추상화 타입으로 변경 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shine-17
commented
Dec 15, 2024
shine-17
commented
- 메서드의 파라미터 타입을 추상화 타입으로 변경
- service에서 mapper 제거 및 repository에서 mapper를 이용한 객체 변환 수행
- 헝가리안 표기법 제거
service에서 mapper 제거 및 repository에서 mapper를 이용한 객체 변환 수행
f-lab-tomo
approved these changes
Dec 15, 2024
| this.bookMapper = bookMapper; | ||
| } | ||
|
|
||
| public static Map<Long, BookEntity> books = new HashMap<>(){{ |
There was a problem hiding this comment.
이전 방식이 books의 타입이 <Long, Book> 이었던 코드를 말씀하시는 건가요?! 테스트 객체지만 추후에 DB와는 Entity로 주고받기 때문에 미리 느낌을 보려고 변경해봤습니다 ㅎㅎ
| import java.util.List; | ||
|
|
||
| public interface BookService { | ||
| // 도서 조회 (id) | ||
| Book findById(long bookId); | ||
|
|
||
| // 도서 목록 조회 (id list) | ||
| List<Book> findByIdList(List<Long> bookIdList); | ||
| List<Book> findByIdList(Collection<Long> bookIds); |
There was a problem hiding this comment.
코드를 변경하면서 메서드명을 보고도 아무생각없이 지나쳤던 제 자신을 반성합니다... 😥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.