[#7] JWT인증구현 #8
Merged
[#7] JWT인증구현 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-namu
reviewed
Dec 12, 2024
| @Post('/signin') | ||
| @UseGuards(LocalAuthGuard) | ||
| async singin(@Request() req){ | ||
| return this.authService.signin(req.user); |
There was a problem hiding this comment.
custom decorator 를 통해 더 개선된 코드를 작성할 수 있을 것 같아요.
There was a problem hiding this comment.
새로 PR로 올렸습니다!
이때 기존 브랜치에 수정한게 아니라 새로만든 브랜치에 코드를 수정해서 신규 PR로 올리게 되었습니다ㅜㅜ
f-lab-namu
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JWT토큰과 passport 미들웨어를 적용하여
로그인시 토큰이 발급되고, 토큰이 검증될 수 있도록 추가하였습니다.