Feature/15: 회원 관리 기능 DB와 연동 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
KanuBang
commented
Jan 10, 2025
KanuBang
commented
- 회원가입
- 프로필 조회
- 프로필 수정 위 기능을 DB와 연동했습니다.
- 회원가입 - 프로필 조회 - 프로필 수정 위 기능을 DB와 연동했습니다.
|
f-lab-lyan
reviewed
Jan 12, 2025
| @@ -9,12 +9,16 @@ | |||
| @Configuration | |||
| @Profile("!test") | |||
| public class WebMvcConfig implements WebMvcConfigurer { | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
사용하지 않는 기능은 주석처리를 하지않고, 지우는 것이 좋은 것 같아요. 나중에 필요하면, 다시 넣으면 되지 않을까요? :-)
f-lab-lyan
reviewed
Jan 12, 2025
| Member savedMember = memberService.addMember(memberForm); | ||
| return ResponseEntity.status(201).body(savedMember); | ||
| MemberDTO memberDTO = MemberDTO.createMemberDTO(savedMember); | ||
| return ResponseEntity.status(201).body(memberDTO); |
There was a problem hiding this comment.
f-lab-lyan
reviewed
Jan 12, 2025
| // 사용자 프로필 수정 | ||
| @PutMapping("/{user_id}/edit") | ||
| public ResponseEntity<Member> memberModify(@PathVariable(value = "user_id") Long user_id, @Valid @RequestBody MemberEditForm memberEditForm) { | ||
| public ResponseEntity<MemberDTO> memberModify(@PathVariable(value = "user_id") Long user_id, @Valid @RequestBody MemberEditForm memberEditForm) { |
There was a problem hiding this comment.
경우에 따라 다를 수도 있지만, 이 컨트롤러에서는 DTO를 하나로 통일하는 것도 괜찮은 아이디어 같습니다.
f-lab-lyan
reviewed
Jan 12, 2025
| @@ -11,23 +13,27 @@ | |||
| @Slf4j | |||
| @Repository | |||
| public class MemberRepository { | |||
| private ConcurrentHashMap<Long, Member> store = new ConcurrentHashMap<>(); | |||
|
|
|||
| @PersistenceContext | |||
There was a problem hiding this comment.
오 ... 뭔가 JPA를 안쓰는 이유가 특별히 있는 것인가요? 아니면, 아직 JPA는 공부중이라 다른 걸 먼저 시도해 보신건가요?
f-lab-lyan
reviewed
Jan 12, 2025
| // 회원가입 | ||
| public Member addMember(MemberForm memberForm){ | ||
| return memberRepository.save(Member.createMember(memberForm)); | ||
| @Transactional |
There was a problem hiding this comment.
save 할 때도 @transactional이 필요한 것인가요?
f-lab-lyan
reviewed
Jan 12, 2025
| @@ -38,14 +48,21 @@ public Member findMember(Long user_id){ | |||
|
|
|||
| // 사용자 프로필 수정 | |||
| @PutMapping("/{user_id}/edit") | |||
There was a problem hiding this comment.
이 annotation은 여기에 적절하진 않은 것 같네요. :-)
f-lab-lyan
reviewed
Jan 12, 2025
| private int following; | ||
| private int point; | ||
|
|
||
| public static MemberDTO createMemberDTO(Member member) { |
There was a problem hiding this comment.
MemberDTO를 생성하는 방법은 createMemberDTO인가요? Builder인가요?
f-lab-lyan
approved these changes
Jan 12, 2025
This was referenced Jan 15, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.