Skip to content

fix GetUserTradesByOrder returning wrong type #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix GetUserTradesByOrder returning wrong type #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api_trading.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ func (c *Client) GetUserTradesByInstrumentAndTime(params *models.GetUserTradesBy
return
}

func (c *Client) GetUserTradesByOrder(params *models.GetUserTradesByOrderParams) (result models.GetUserTradesResponse, err error) {
func (c *Client) GetUserTradesByOrder(params *models.GetUserTradesByOrderParams) (result []models.Trade, err error) {
err = c.Call("private/get_user_trades_by_order", params, &result)
return
}
Expand Down
53 changes: 52 additions & 1 deletion client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ package deribit

import (
"encoding/json"
"testing"

"github.com/frankrap/deribit-api/models"
"github.com/stretchr/testify/assert"
"testing"
)

func newClient() *Client {
Expand Down Expand Up @@ -135,6 +136,56 @@ func TestClient_Buy(t *testing.T) {
t.Logf("%#v", result)
}

func TestClient_GetUserTradesByOrder(t *testing.T) {
client := newClient()
params := &models.BuyParams{
InstrumentName: "BTC-PERPETUAL",
Amount: 10,
Price: 20000.0,
Type: "market",
Label: "TestClient_CancelByLabel",
}
buyResult, err := client.Buy(params)
if err != nil {
t.Fatal(err)
}

t.Logf("%#v", buyResult)

getTradesRes, err := client.GetUserTradesByOrder(&models.GetUserTradesByOrderParams{OrderID: buyResult.Order.OrderID})

if err != nil {
t.Fatal(err)
}

if actualTradesCount := len(getTradesRes); actualTradesCount == 0 {
t.Errorf("no Trades")
}

if expectTradesCount, actualTradesCount := len(buyResult.Trades), len(getTradesRes); expectTradesCount != actualTradesCount {
t.Fatalf("Expected trades count %d, actual: %d", expectTradesCount, actualTradesCount)
}

for i, trade := range buyResult.Trades {
if trade.TradeSeq != getTradesRes[i].TradeSeq {
t.Errorf("Expected TradeSeq %d, actual %d", trade.TradeSeq, getTradesRes[i].TradeSeq)
}

if trade.TradeID != getTradesRes[i].TradeID {
t.Errorf("Expected TradeID %s, actual %s", trade.TradeID, getTradesRes[i].TradeID)
}

if trade.Amount != getTradesRes[i].Amount {
t.Errorf("Expected Amount %f, actual %f", trade.Amount, getTradesRes[i].Amount)
}

if trade.Price != getTradesRes[i].Price {
t.Errorf("Expected Price %f, actual %f", trade.Price, getTradesRes[i].Price)
}
}

}

func TestJsonOmitempty(t *testing.T) {
params := &models.BuyParams{
InstrumentName: "BTC-PERPETUAL",
Expand Down