reduce filesize and performance optimization #429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduce filesize by some code fixes
Remark 1: Reason for changing
this.each ( callback )
toeach ( this, callback )
For the code minimization,
this.each(
will be reduced tod(
Remark 2: changing
wrapper.children.length
towrapper.firstElementChild
When calling
children
, it will create a newNodeList
that containing all the sub-elements under the elementwrapper
.As this is just to check whether there is any element child or not,
firstElementChild
orlastElementChild
shall be used for performance consideration.Remark 3:
.insertBefore ( ele, null );
is the same as.appendChild ( ele );