Chamelon sense fabric modify #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abessiari
commented
Mar 11, 2024
abessiari
commented
- chameleon tested with modify
- fabric tested with modify. Added the delete of network
- improved fabric loading of things like dataplane by removing from constructor
- improved state management
- sense is in unmodifiable as is cloudlab and so modifying the config will result in delete and then provision
|
It displays "all checks have passed," yet upon closer examination, the "fabric facility ports" check reveals error messages. |
Yes I saw that. I got tired of regenerating a token .... Work in progress. Waiting for komal to have a fix for long term tokens ... |
xi-yang
approved these changes
Mar 11, 2024
abessiari
added a commit
that referenced
this pull request
Apr 25, 2024
* initial modify * handling chameleon modify * removing extra log and semicolon * revisited cloudlab * handling sense, chameleon, fabric, better state reconciliation during exceptions * use NIC_Basic for illustration config
abessiari
added a commit
that referenced
this pull request
Apr 25, 2024
* initial modify * handling chameleon modify * removing extra log and semicolon * revisited cloudlab * handling sense, chameleon, fabric, better state reconciliation during exceptions * use NIC_Basic for illustration config
abessiari
added a commit
that referenced
this pull request
Apr 25, 2024
* initial modify * handling chameleon modify * removing extra log and semicolon * revisited cloudlab * handling sense, chameleon, fabric, better state reconciliation during exceptions * use NIC_Basic for illustration config
abessiari
added a commit
that referenced
this pull request
Apr 25, 2024
* initial modify * handling chameleon modify * removing extra log and semicolon * revisited cloudlab * handling sense, chameleon, fabric, better state reconciliation during exceptions * use NIC_Basic for illustration config
abessiari
added a commit
that referenced
this pull request
Apr 25, 2024
* initial modify * handling chameleon modify * removing extra log and semicolon * revisited cloudlab * handling sense, chameleon, fabric, better state reconciliation during exceptions * use NIC_Basic for illustration config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.