-
Notifications
You must be signed in to change notification settings - Fork 29
WIP: Create contract tests for interaction with Auth service. #659
base: master
Are you sure you want to change the base?
Conversation
Can one of the admins verify this patch? |
0ce4f49
to
6d5fcbc
Compare
|
||
# Configuration of contract tests | ||
PACT_VERSION ?= 1.0.0 | ||
PACT_BROKER_URL ?= http://pact-broker-pact-broker.193b.starter-ca-central-1.openshiftapps.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't relay on OSO-starter to run the broker. Need a better place for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the same home as sentry and ike bots? /cc @kbsingh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah.. it should be preview or prod cluster. @pmacik talk to the SD team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexeykazakov @bartoszmajsak Thanks for the suggestion, created appropriate SD ticket for that (https://gitlab.cee.redhat.com/dtsd/housekeeping/issues/2383)
Who is a provider and who is a consumer here? Or in other words - where can I see auth tests? |
Few other points
|
@bartoszmajsak The provider is the Auth service ( It's still a WIP so both contract sides are in the same place, but the auth tests (the provider tests) are the part verifying the pact file taken from broker against a living auth service instance (= |
ceb190a
to
f303764
Compare
No description provided.