Feature to register analytics plugin only if available #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyush-garg
changed the title
piyush-garg
added
feature
piyush-garg
added a commit
to piyush-garg/fabric8-tenant
that referenced
this pull request
Jan 31, 2019
Add some scripts for Jenkins required to merge the patch fabric8io/osio-pipeline#116 Fixes fabric8io/osio-pipeline#74
|
We need to merge fabric8-services/fabric8-tenant#743 and do the tenant update before merging this. |
you are right, and the tenant update process takes time |
piyush-garg
added a commit
to piyush-garg/fabric8-tenant
that referenced
this pull request
Feb 7, 2019
Add some scripts for Jenkins required to merge the patch fabric8io/osio-pipeline#116 Fixes fabric8io/osio-pipeline#74
piyush-garg
force-pushed
the
iss_74
branch
2 times, most recently
from
614e32e
to
465400f
Compare
piyush-garg
added a commit
to piyush-garg/fabric8-tenant
that referenced
this pull request
Feb 13, 2019
Add some scripts for Jenkins required to merge the patch fabric8io/osio-pipeline#116 Fixes fabric8io/osio-pipeline#74
piyush-garg
added a commit
to fabric8-services/fabric8-tenant
that referenced
this pull request
Feb 13, 2019
Add some scripts for Jenkins required to merge the patch fabric8io/osio-pipeline#116 Fixes fabric8io/osio-pipeline#74
sthaha
reviewed
Feb 13, 2019
This patch will add a feature to register Analytics Plugin only if it is there in jenkins Fixes fabric8io#74
|
@sthaha Addressed your review comments. Can you please take a look now? |
hrishin
approved these changes
Feb 14, 2019
sthaha
approved these changes
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will add a feature to register
Analytics Plugin only if it is there in jenkins
Fixes #74