Fix custom fonts (requires libpango) #3519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node-canvas fixed custom font loading in v1.6.1 by merging this PR: Automattic/node-canvas#715 It was broken for almost 2 years, although it could be avoided by removing libpango and reinstalling node-canvas (see #3272), that also removed some other functionality (which I'm not sure fabric uses), and with 1.6.1 they explicitly require libpango. I think fabric should use canvas ~1.6.1 (same as "1.6.x", but excluding 1.6.0), because otherwise the same version of fabric could use different versions of node-canvas and this problem could still occur for people who have installed canvas explicitly or through other dependencies. Fixes #3272 and #2514
asturur
reviewed
Dec 10, 2016
|
@asturur I have fabricjs 1.7.1. Currently the dependencies are canvas 1.6.x, jsdom 3.x.x, and xmldom 0.1.x. In the next fabricjs release, are you changing the canvas version to 1.6.1, 1.6.2, or something else? |
|
latest that do not break unit tests |
|
This doesn't work. I misread the releases git commit list and managed to install the wrong libpango package. Two failures that together made it seem like it was fixed. Very sorry! On the bright side it looks like we'll get a fix in 2.0.0 in a not too distant future, and I'll keep my trigger happy PR-fingers in check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node-canvas fixed custom font loading in v1.6.1 by merging this PR: Automattic/node-canvas#715
It was broken for almost 2 years, although it could be avoided by removing libpango and reinstalling node-canvas (see #3272), that also removed some other functionality (which I'm not sure fabric uses), and with 1.6.1 they explicitly require libpango.
I think fabric should use canvas ~1.6.1 (same as "1.6.x", but excluding 1.6.0), because otherwise the same version of fabric could use different versions of node-canvas and this problem could still occur for people who have installed canvas explicitly or through other dependencies.
Fixes #2514, #3208 and #3272 (duplicates)