update CV adhoc method to have dedicated method and leverage adapter in core compute #3477
+122
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70722408 |
mgarrard
force-pushed
the
export-D70722408
branch
from
e6dbc0f to
199f7a9
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Mar 7, 2025
…in core compute (facebook#3477) Summary: Earlier this week I put up a series of diffs that updated the CV plot and exposed adhoc usage, this diff updates that method per some offline discussion with Miles/Lena about how to best access these adhoc methods, and also leverages the argument "adapter" that's been added to compute method. Only remaining items for the CV plot is add relativization (which is backlog for all pts plots) + tiling (actively wip diffs up by Cesar and Miles) Reviewed By: lena-kashtelyan Differential Revision: D70722408
|
This pull request was exported from Phabricator. Differential Revision: D70722408 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3477 +/- ##
=======================================
Coverage 96.02% 96.03%
=======================================
Files 539 539
Lines 52920 52936 +16
=======================================
+ Hits 50818 50835 +17
+ Misses 2102 2101 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…in core compute (facebook#3477) Summary: Earlier this week I put up a series of diffs that updated the CV plot and exposed adhoc usage, this diff updates that method per some offline discussion with Miles/Lena about how to best access these adhoc methods, and also leverages the argument "adapter" that's been added to compute method. Only remaining items for the CV plot is add relativization (which is backlog for all pts plots) + tiling (actively wip diffs up by Cesar and Miles) Reviewed By: lena-kashtelyan Differential Revision: D70722408
mgarrard
force-pushed
the
export-D70722408
branch
from
199f7a9 to
e61b9c8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70722408 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Earlier this week I put up a series of diffs that updated the CV plot and exposed adhoc usage, this diff updates that method per some offline discussion with Miles/Lena about how to best access these adhoc methods, and also leverages the argument "adapter" that's been added to compute method.
Differential Revision: D70722408