Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make knife verbose if logging level is DEBUG or INFO #104

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

ifel
Copy link
Contributor

@ifel ifel commented Aug 21, 2019

Fix for facebook/taste-tester#122

taste-tester uses between-meals to run knife commands. If it's verbose (INFO or DEBUG), make knife verbose too to simplify debug.

Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I was going to get around to it, but I'm stoked you did.

Just one question about the log level...

lib/between_meals/knife.rb Show resolved Hide resolved
lib/between_meals/knife.rb Show resolved Hide resolved
lib/between_meals/knife.rb Show resolved Hide resolved
@ifel
Copy link
Contributor Author

ifel commented Aug 21, 2019

Thank you for reviewing and hints!

@ifel ifel merged commit fcf04ab into facebook:master Aug 21, 2019
@jaymzh
Copy link
Collaborator

jaymzh commented Aug 21, 2019

We may want to do this differently. I just tested this, and to get the ACTUAL file with an issue you need three Vs. So maybe info is VV and debug is VVV?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants