Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addcslashes(), strpos(): Passing null to parameter #1 ($string) of type string is deprecated #616

Closed
wants to merge 2 commits into from

Conversation

mbvb1223
Copy link
Contributor

`Deprecated: addcslashes(): Passing null to parameter #1 ($string) of type string is deprecated {"exception":"[object] (ErrorException(code: 0): Deprecated: addcslashes(): Passing null to parameter #1 ($string) of type string is deprecated at /app/vendor/facebook/php-business-sdk/src/FacebookAds/Logger/CurlLogger.php:160)"} []

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated {"exception":"[object] (ErrorException(code: 0): Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated at /app/vendor/facebook/php-business-sdk/src/FacebookAds/Logger/CurlLogger.php:161)"} []`

@facebook-github-bot
Copy link

Hi @mbvb1223!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@@ -157,6 +157,7 @@ protected function processParams(Parameters $params, $method, $is_file) {
if ($is_file && $params->offsetGet($name) instanceof FileParameter) {
$value = "@" . $this->normalizeFileParam($params->offsetGet($name));
} else {
$value = (string) $value;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@facebook-github-bot
Copy link

@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit to facebook/facebook-business-sdk-codegen that referenced this pull request Dec 20, 2024
…f type string is deprecated

Summary:
`Deprecated: addcslashes(): Passing null to parameter facebook/facebook-php-business-sdk#1 ($string) of type string is deprecated {"exception":"[object] (ErrorException(code: 0): Deprecated: addcslashes(): Passing null to parameter facebook/facebook-php-business-sdk#1 ($string) of type string is deprecated at /app/vendor/facebook/php-business-sdk/src/FacebookAds/Logger/CurlLogger.php:160)"} []

Deprecated: strpos(): Passing null to parameter facebook/facebook-php-business-sdk#1 ($haystack) of type string is deprecated {"exception":"[object] (ErrorException(code: 0): Deprecated: strpos(): Passing null to parameter facebook/facebook-php-business-sdk#1 ($haystack) of type string is deprecated at /app/vendor/facebook/php-business-sdk/src/FacebookAds/Logger/CurlLogger.php:161)"} []`

X-link: facebook/facebook-php-business-sdk#616

Reviewed By: liliarizona

Differential Revision: D67467808

Pulled By: stcheng

fbshipit-source-id: 39b7f5e24b5b0314fcbaa271169c5c23b3b2afe0
@facebook-github-bot
Copy link

@stcheng merged this pull request in ef5a6d9.

@mbvb1223 mbvb1223 deleted the fix_deprecated_curl_logger branch January 7, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants