Skip to content

Commit

Permalink
Drop generating "compat setter pointer" for optional set thrift fields
Browse files Browse the repository at this point in the history
Summary:
Fire!

#build_rule_type[go_library,go_binary,go_unittest,go_test]

Reviewed By: echistyakov

Differential Revision: D68407032

fbshipit-source-id: dd22d5e655672244a9f98253842e97329c0679ed
  • Loading branch information
inesusvet authored and facebook-github-bot committed Jan 22, 2025
1 parent 59aada9 commit 02e86b9
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ class mstch_go_field : public mstch_field {
bool has_default_value = (field_->default_value() != nullptr);
if (is_optional_() && has_default_value) {
auto real_type = field_->type()->get_true_type();
bool is_container = (real_type->is_map() || real_type->is_set());
bool is_container = real_type->is_map();
return is_container;
}
return is_pointer_();
Expand Down

0 comments on commit 02e86b9

Please sign in to comment.