-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
folly async io_uring: bump EVB start time on IoSqeBase completion
Summary: `EventHandler::libeventCallback()` calls `EventBase::bumpHandlingTime()` which sets the `startTime_` of an EVB loop iteration if it wasn't already set. If no `EventHandler`s are run, then `startTime_` is bumped just before running loop callbacks. The io_uring based `IoUringBackend` and `AsyncIoUringSocket` do not use `EventHandler`. Thus the `startTime_` of an EVB loop iteration is not being set correctly upon handling the first piece of I/O work via the various `IoSqeBase` types. Fix this by adding the EventBase to that an IoSqeBase is tied to, and call `EventBase::bumpHandlingTime()` when completing an IoSqeBase i.e. invoking its callback. Reviewed By: yfeldblum Differential Revision: D68537153 fbshipit-source-id: 9e991213d69ffa32778e06a0fb447b0514bebba5
- Loading branch information
1 parent
82528a9
commit 5f1eba8
Showing
3 changed files
with
7 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters