Skip to content

Commit

Permalink
Remove getdeps dependency on Python 3.8
Browse files Browse the repository at this point in the history
Summary:
X-link: facebookincubator/zstrong#1175

Instead of having fbthrift download and build Python 3.8 (which is ancient), users should be able to build fbthrift against the target Python environment. (This is consistent with how Python packages would normally be built/installed.)

Note that users can specify their target version of Python via the `PYTHON_LIBRARY` and `PYTHON_INCLUDE_DIR` CMake variables, as demonstrated in the command in the test plan.

Reviewed By: vladmihailescu

Differential Revision: D68510340

fbshipit-source-id: f94805de4220b2c107ed0aa0d57fd23b65b29bd2
  • Loading branch information
jmswen authored and facebook-github-bot committed Feb 7, 2025
1 parent 75f0a03 commit bbce75d
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions build/fbcode_builder/manifests/fbthrift
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@ xxhash
# specific configuration we rely on the folly manifest to provide this
# dependency to avoid duplication.

[dependencies.os=linux]
# python doesn't build on Windows yet and this causes python3 shebangs to
# expand to a non-portable path on macOS
python

[shipit.pathmap]
xplat/thrift/public_tld = .
xplat/thrift = thrift
Expand Down

0 comments on commit bbce75d

Please sign in to comment.