Skip to content

Commit

Permalink
Remove coeffects from listIdentifiers and listAbbreviations, marking …
Browse files Browse the repository at this point in the history
…them as impure

Summary: See D67602326 and T211026366.  These functions are incorrectly marked as pure, but pull impure data from sources external to WWW.  This causes issues for codegen, which can become non-deterministic due to the lack of hermeticity of these functions.

Reviewed By: latrekc

Differential Revision: D67602402

fbshipit-source-id: 3ff8fb589051a750ffdd3ec19156ef8ad341a88b
  • Loading branch information
Craig Phillips authored and facebook-github-bot committed Jan 7, 2025
1 parent 41e20ae commit f073bea
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions hphp/hack/hhi/stdlib/builtins_datetime.hhi
Original file line number Diff line number Diff line change
Expand Up @@ -395,11 +395,11 @@ class DateTimeZone {
int $timestamp_begin = PHP_INT_MIN,
int $timestamp_end = PHP_INT_MAX,
)[]: HH\FIXME\MISSING_RETURN_TYPE;
static public function listAbbreviations()[]: HH\FIXME\MISSING_RETURN_TYPE;
static public function listAbbreviations(): HH\FIXME\MISSING_RETURN_TYPE;
static public function listIdentifiers(
int $what = 2047,
string $country = '',
)[]: HH\FIXME\MISSING_RETURN_TYPE;
): HH\FIXME\MISSING_RETURN_TYPE;
}

class DateInterval {
Expand Down

0 comments on commit f073bea

Please sign in to comment.