Skip to content

AArch64: Add support for more extending loads #9657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AArch64: Add support for more extending loads #9657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions hphp/runtime/vm/jit/vasm-simplify-arm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,26 +91,28 @@ bool simplify(Env& env, const cmovq& inst, Vlabel b, size_t i) {

///////////////////////////////////////////////////////////////////////////////

bool simplify(Env& env, const loadb& inst, Vlabel b, size_t i) {
if (if_inst<Vinstr::movzbl>(env, b, i + 1, [&] (const movzbl& mov) {
// loadb{s, tmp}; movzbl{tmp, d}; -> loadzbl{s, d};
if (!(env.use_counts[inst.d] == 1 && inst.d == mov.s)) return false;
template <Vinstr::Opcode ExtOp, typename ExtMov, typename ExtLoad, typename Load>
bool simplify_load_ext(Env& env, const Load& inst, Vlabel b, size_t i) {
return if_inst<ExtOp>(env, b, i + 1, [&] (const ExtMov& mov) {
if (env.use_counts[inst.d] != 1 || inst.d != mov.s) return false;

return simplify_impl(env, b, i, [&] (Vout& v) {
v << loadzbl{inst.s, mov.d};
v << ExtLoad{inst.s, mov.d};
return 2;
}); })) {
return true;
}

return if_inst<Vinstr::movsbl>(env, b, i + 1, [&] (const movsbl& mov) {
// loadb{s, tmp}; movsbl{tmp, d}; -> loadsbl{s, d};
if (!(env.use_counts[inst.d] == 1 && inst.d == mov.s)) return false;
});
});
}

return simplify_impl(env, b, i, [&] (Vout& v) {
v << loadsbl{inst.s, mov.d};
return 2;
}); });
bool simplify(Env& env, const loadb& inst, Vlabel b, size_t i) {
if (simplify_load_ext<Vinstr::movzbl, movzbl, loadzbl>(env, inst, b, i))
return true;
if (simplify_load_ext<Vinstr::movzbq, movzbq, loadzbq>(env, inst, b, i))
return true;
if (simplify_load_ext<Vinstr::movsbl, movsbl, loadsbl>(env, inst, b, i))
return true;
if (simplify_load_ext<Vinstr::movsbq, movsbq, loadsbq>(env, inst, b, i))
return true;
return false;
}

///////////////////////////////////////////////////////////////////////////////
Expand Down