Remove outdated functionality from the build system #9662
+52
−4,406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HHVM CMake build contains various bits that are outdated or never really were supported to begin with. The resulting bloat makes the build files harder to maintain. So, reduce the complexity by eliminating dead build logic: * Remove MSVC-specific build logic. HHVM support on Windows was only ever experimental and was not worked on from 2018 onwards. * Remove Cotire, an 11-year old experiment for precompiling headers. * Drop checks and conditional blocks for very old clang and gcc versions. Since we require C++20, any attempt to build on such archaic compiler versions would fail fast. * Drop configuration specific to the Intel C++ compiler. * Remove unused CPACK_GENERATOR option. * Remove SSE4.2 and AVX2 toggles in favor of `march=x86-64-v3`.
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D86521728. (Because this pull request was imported automatically, there will not be any future comments.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HHVM CMake build contains various bits that are outdated or never really were supported to begin with. The resulting bloat makes the build files harder to maintain. So, reduce the complexity by eliminating dead build logic:
march=x86-64-v3.