Skip to content

Commit

Permalink
Use --server_name override when setting the host header
Browse files Browse the repository at this point in the history
Summary: The `--server_name` override wasn't being honored when setting the host header, defaulting to the `--server` flag's value. This diff changes that.

Reviewed By: lnicco

Differential Revision: D50695638

fbshipit-source-id: f62d956a3f937ca3260a3e91862239eb2e700836
  • Loading branch information
Utku Gürkan authored and facebook-github-bot committed Nov 1, 2023
1 parent 2fae54d commit 844d518
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions proxygen/httpclient/samples/httperf2/HTTPerf2.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -336,12 +336,17 @@ ClientRunner::ClientRunner(HTTPerfStats& parentStats,
request_.setMethod(HTTPMethod::GET);
}

serverName_ = FLAGS_server;
if (!FLAGS_server_name.empty()) {
serverName_ = FLAGS_server_name;
}

if (FLAGS_http10) {
request_.setHTTPVersion(1, 0);
} else {
request_.setHTTPVersion(1, 1);
if (!FLAGS_nohost) {
request_.getHeaders().add(HTTP_HEADER_HOST, FLAGS_server);
request_.getHeaders().add(HTTP_HEADER_HOST, serverName_);
}
}

Expand Down Expand Up @@ -370,10 +375,6 @@ ClientRunner::ClientRunner(HTTPerfStats& parentStats,
request_.getHeaders().add(headerName, header.substr(pos));
}
}
serverName_ = FLAGS_server;
if (!FLAGS_server_name.empty()) {
serverName_ = FLAGS_server_name;
}
}

void ClientRunner::run() {
Expand Down

0 comments on commit 844d518

Please sign in to comment.