Fix an issue where the status bar colors would not match when opening modals

[Abbondanzo]

Summary:

The current ReactModalHostView implementation incorrectly applies system bar appearances by providing the wrong mask to the setSystemBarsAppearance method invocation. Per this issue comment, @jaydonlau correctly identified that when the status bar is set to light-content (light icons, dark background), the function is called with both a 0 appearance and 0 mask, which should instead be provided with the APPEARANCE_LIGHT_STATUS_BARS mask.

The first pass at this PR attempted to pull out the entire appearance from the activity, compare it against the dialog's appearance, and only use a mask of differing bits (see the appearanceMask variable). However, if the android:windowLightStatusBar attribute is ever set to true, this does not impact the appearance of the status bar but rather the system UI visibility. As a result, the derived mask from system bars appearance would be 0 since both the activity and dialog would have appearances of 0.

Rather than try and "future-proof" this implementation for other uses of system bar appearance, this change is directed only at updating the APPEARANCE_LIGHT_STATUS_BARS bit in the dialog's system bar appearance. The only other native code that touches status bars is the StatusBarModule and that only touches this flag.

This is a follow-up to #34899.

Changelog:

[ANDROID] [FIXED] - Fixed an issue where the status bar colors would not match when opening modals

Test Plan:

First test:

• Replace the RNTesterAppShared implementation with the implementation from this Expo snack
• Toggle the status bar to show dark icons, open the modal and ensure that dark icons are displayed
• Toggle the status bar to show light icons, open the modal and ensure that light icons are displayed

Second test:

• Set the android:windowLightStatusBar attribute to true in the AppTheme
• Follow the steps from the First test above, guaranteeing that status bar appearance overrides the theme

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	17,214,614	-12
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	20,587,380	+5
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: a2f1189
Branch: main

[github-actions]

	Warnings
⚠️	One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against dc76851

[facebook-github-bot]

@luluwu2032 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[github-actions]

This pull request was successfully merged by Peter Abbondanzo in e8d622e.

^{When will my fix make it into a release? | Upcoming Releases}