Merge remote-tracking branch 'upstream/main'

facebook · Oct 27, 2024 · ab2e546 · ab2e546
2 parents 617df88 + fe04dbc
commit ab2e546
Show file tree

Hide file tree

Showing 517 changed files with 34,431 additions and 10,369 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -23,6 +23,7 @@ module.exports = {
     'babel',
     'ft-flow',
     'jest',
+    'es',
     'no-for-of-loops',
     'no-function-declare-after-return',
     'react',
@@ -47,7 +48,7 @@ module.exports = {
     'ft-flow/no-unused-expressions': ERROR,
     // 'ft-flow/no-weak-types': WARNING,
     // 'ft-flow/require-valid-file-annotation': ERROR,
-
+    'es/no-optional-chaining': ERROR,
     'no-cond-assign': OFF,
     'no-constant-condition': OFF,
     'no-control-regex': OFF,
@@ -435,6 +436,7 @@ module.exports = {
         'packages/react-dom/src/test-utils/*.js',
       ],
       rules: {
+        'es/no-optional-chaining': OFF,
         'react-internal/no-production-logging': OFF,
         'react-internal/warning-args': OFF,
         'react-internal/safe-string-coercion': [
@@ -567,6 +569,7 @@ module.exports = {
     React$Node: 'readonly',
     React$Portal: 'readonly',
     React$Ref: 'readonly',
+    React$RefSetter: 'readonly',
     ReadableStreamController: 'readonly',
     ReadableStreamReader: 'readonly',
     RequestInfo: 'readonly',

diff --git a/.github/ISSUE_TEMPLATE/compiler_bug_report.yml b/.github/ISSUE_TEMPLATE/compiler_bug_report.yml
@@ -55,3 +55,10 @@ body:
       Please provide your React version in the app where this issue occurred.
   validations:
     required: true
+- type: input
+  attributes:
+    label: What version of React Compiler are you using?
+    description: |
+      Please provide the exact React Compiler version in the app where this issue occurred.
+  validations:
+    required: true
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -1,107 +1,10 @@
 version: 2
 updates:
   - package-ecosystem: "npm"
-    directory: "/fixtures/art"
+    directories:
+      - "/fixtures/*"
     schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/attribute-behavior"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/concurrent"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/devtools"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/dom"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/eslint"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/expiration"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/fiber-debugger"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/fiber-triangle"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/fizz"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/fizz-ssr-browser"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/flight"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/flight-browser"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/flight-esm"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/legacy-jsx-runtimes"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/nesting"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/packaging"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/scheduler"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/ssr"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/ssr-2"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/stacks"
-    schedule:
-      interval: "weekly"
+      interval: "monthly"
     open-pull-requests-limit: 0
+    ignore:
+      - dependency-name: "*"
diff --git a/.github/workflows/compiler_playground.yml b/.github/workflows/compiler_playground.yml
@@ -8,14 +8,18 @@ on:
       - compiler/**
       - .github/workflows/compiler-playground.yml
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
+  cancel-in-progress: true
+
 env:
   TZ: /usr/share/zoneinfo/America/Los_Angeles
   # https://github.com/actions/cache/blob/main/tips-and-workarounds.md#cache-segment-restore-timeout
   SEGMENT_DOWNLOAD_TIMEOUT_MINS: 1
 
 defaults:
   run:
-    working-directory: compiler
+    working-directory: compiler/apps/playground
 
 jobs:
   playground:
@@ -28,13 +32,22 @@ jobs:
         with:
           node-version-file: '.nvmrc'
           cache: yarn
-          cache-dependency-path: compiler/yarn.lock
+          cache-dependency-path: compiler/**/yarn.lock
       - name: Restore cached node_modules
         uses: actions/cache@v4
         id: node_modules
         with:
           path: "**/node_modules"
-          key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('compiler/**/yarn.lock') }}
-      - run: yarn
+          key: compiler-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('compiler/**/yarn.lock') }}
+      - name: yarn install compiler
+        run: yarn
+        working-directory: compiler
+      - name: yarn install playground
+        run: yarn
       - run: npx playwright install --with-deps chromium
-      - run: yarn workspace playground test
+      - run: yarn test
+      - name: Archive test results
+        uses: actions/upload-artifact@v4
+        with:
+          name: test-results
+          path: test-results
diff --git a/.github/workflows/compiler_prereleases.yml b/.github/workflows/compiler_prereleases.yml
@@ -13,6 +13,9 @@ on:
       dist_tag:
         required: true
         type: string
+      version_name:
+        required: true
+        type: string
     secrets:
       NPM_TOKEN:
         required: true
@@ -45,9 +48,9 @@ jobs:
         id: node_modules
         with:
           path: "**/node_modules"
-          key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('compiler/**/yarn.lock') }}
+          key: compiler-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('compiler/**/yarn.lock') }}
       - run: yarn
       - name: Publish packages to npm
         run: |
           cp ./scripts/release/ci-npmrc ~/.npmrc
-          scripts/release/publish.js --frfr --ci --tags ${{ inputs.dist_tag }}
+          scripts/release/publish.js --frfr --ci --versionName=${{ inputs.version_name }} --tag ${{ inputs.dist_tag }}
diff --git a/.github/workflows/compiler_prereleases_manual.yml b/.github/workflows/compiler_prereleases_manual.yml
@@ -5,6 +5,15 @@ on:
     inputs:
       prerelease_commit_sha:
         required: false
+      release_channel:
+        required: true
+        type: string
+      dist_tag:
+        required: true
+        type: string
+      version_name:
+        required: true
+        type: string
 
 env:
   TZ: /usr/share/zoneinfo/America/Los_Angeles
@@ -15,7 +24,8 @@ jobs:
     uses: facebook/react/.github/workflows/compiler_prereleases.yml@main
     with:
       commit_sha: ${{ inputs.prerelease_commit_sha || github.sha }}
-      release_channel: experimental
-      dist_tag: experimental
+      release_channel: ${{ inputs.release_channel }}
+      dist_tag: ${{ inputs.dist_tag }}
+      version_name: ${{ inputs.version_name }}
     secrets:
       NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
diff --git a/.github/workflows/compiler_prereleases_nightly.yml b/.github/workflows/compiler_prereleases_nightly.yml
@@ -16,5 +16,6 @@ jobs:
       commit_sha: ${{ github.sha }}
       release_channel: experimental
       dist_tag: experimental
+      version_name: '0.0.0'
     secrets:
       NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
diff --git a/.github/workflows/compiler_prereleases_weekly.yml b/.github/workflows/compiler_prereleases_weekly.yml
@@ -0,0 +1,21 @@
+name: (Compiler) Publish Prereleases Weekly
+
+on:
+  schedule:
+    # At 10 minutes past 9:00 on Mon
+    - cron: 10 9 * * 1
+
+env:
+  TZ: /usr/share/zoneinfo/America/Los_Angeles
+
+jobs:
+  publish_prerelease_beta:
+    name: Publish to beta channel
+    uses: facebook/react/.github/workflows/compiler_prereleases.yml@main
+    with:
+      commit_sha: ${{ github.sha }}
+      release_channel: beta
+      dist_tag: beta
+      version_name: '19.0.0'
+    secrets:
+      NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
diff --git a/.github/workflows/compiler_rust.yml b/.github/workflows/compiler_rust.yml
@@ -15,6 +15,10 @@ on:
       - compiler/Cargo.*
       - compiler/*.toml
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
+  cancel-in-progress: true
+
 env:
   CARGO_TERM_COLOR: always
   RUSTFLAGS: -Dwarnings

diff --git a/.github/workflows/compiler_typescript.yml b/.github/workflows/compiler_typescript.yml
@@ -8,6 +8,10 @@ on:
       - compiler/**
       - .github/workflows/compiler_typescript.yml
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
+  cancel-in-progress: true
+
 env:
   TZ: /usr/share/zoneinfo/America/Los_Angeles
   # https://github.com/actions/cache/blob/main/tips-and-workarounds.md#cache-segment-restore-timeout
@@ -44,7 +48,7 @@ jobs:
         uses: actions/cache@v4
         with:
           path: "**/node_modules"
-          key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('compiler/**/yarn.lock') }}
+          key: compiler-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('compiler/**/yarn.lock') }}
       - run: yarn
       - run: yarn workspace babel-plugin-react-compiler lint
 
@@ -65,7 +69,7 @@ jobs:
         id: node_modules
         with:
           path: "**/node_modules"
-          key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('compiler/**/yarn.lock') }}
+          key: compiler-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('compiler/**/yarn.lock') }}
       - run: yarn
       - run: yarn workspace babel-plugin-react-compiler jest
 
@@ -90,6 +94,6 @@ jobs:
         id: node_modules
         with:
           path: "**/node_modules"
-          key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('compiler/**/yarn.lock') }}
+          key: compiler-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('compiler/**/yarn.lock') }}
       - run: yarn
       - run: yarn workspace ${{ matrix.workspace_name }} test
diff --git a/.github/workflows/devtools_regression_tests.yml b/.github/workflows/devtools_regression_tests.yml
@@ -31,7 +31,7 @@ jobs:
         id: node_modules
         with:
           path: "**/node_modules"
-          key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('yarn.lock', 'scripts/release/yarn.lock') }}
+          key: runtime-release-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock', 'scripts/release/yarn.lock') }}
       - run: yarn
         working-directory: scripts/release
       - name: Download react-devtools artifacts for base revision
@@ -63,7 +63,7 @@ jobs:
         id: node_modules
         with:
           path: "**/node_modules"
-          key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('yarn.lock') }}
+          key: runtime-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
       - run: yarn
       - name: Restore archived build
         uses: actions/download-artifact@v4
@@ -104,6 +104,7 @@ jobs:
           - "16.8" # hooks
           - "17.0"
           - "18.0"
+          - "18.2" # compiler polyfill
     continue-on-error: true
     steps:
       - uses: actions/checkout@v4
@@ -118,7 +119,7 @@ jobs:
         id: node_modules
         with:
           path: "**/node_modules"
-          key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('yarn.lock') }}
+          key: runtime-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
       - run: yarn
       - name: Restore all archived build artifacts
         uses: actions/download-artifact@v4
@@ -153,7 +154,7 @@ jobs:
         id: node_modules
         with:
           path: "**/node_modules"
-          key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('yarn.lock') }}
+          key: runtime-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
       - run: yarn
       - name: Restore all archived build artifacts
         uses: actions/download-artifact@v4