-
Notifications
You must be signed in to change notification settings - Fork 46.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compiler] Test fixture: non-reactive phi creates 'dangling ref' scope #31103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Sep 30, 2024
mofeiZ
added a commit
that referenced
this pull request
Sep 30, 2024
ghstack-source-id: 2a6f36d2c02186e87707715c64d25178422c84f8 Pull Request resolved: #31103
facebook-github-bot
added
the
React Core Team
Opened by a member of the React Core Team
label
Sep 30, 2024
[ghstack-poisoned]
mofeiZ
added a commit
that referenced
this pull request
Sep 30, 2024
ghstack-source-id: 5dba5c0b1d2e17c1d8d8a88a363f28ad7ac4746a Pull Request resolved: #31103
[ghstack-poisoned]
mofeiZ
added a commit
that referenced
this pull request
Oct 1, 2024
ghstack-source-id: dc8753a36d21db3fb596bf3c3b4b55fe9f6f995d Pull Request resolved: #31103
josephsavona
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super interesting. We should discuss what the fix is for this case
[ghstack-poisoned]
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):