[string-refs] log string ref from prod #31161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kassens
force-pushed
the
pr31161
branch
2 times, most recently
from
e5f148d
to
9b55fcc
Compare
packages/shared/ReactFeatureFlags.js
Outdated
| @@ -215,6 +215,7 @@ export const disableClientCache = true; | |||
| // during element creation. | |||
| export const enableRefAsProp = true; | |||
| export const disableStringRefs = true; | |||
| export const logStringRefs: null | ((string, string) => void) = null; | |||
There was a problem hiding this comment.
Can you rename this to have the enable prefix, and call out "prod"? like enableLogStringRefsProd
rickhanlonii
approved these changes
Oct 10, 2024
If passed as a feature flag, this calls the configured function when a string ref is used even from prod code to find the last usages.
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If passed as a feature flag, this calls the configured function when a string ref is used even from prod code to find the last usages.