Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ref Lifecycles in Hidden Subtrees #31379

Merged
merged 10 commits into from
Oct 31, 2024
Merged

Fix Ref Lifecycles in Hidden Subtrees #31379

merged 10 commits into from
Oct 31, 2024
+140 −9

Commits on Oct 28, 2024

  1. Avoid Detaching Refs on Hidden Subtrees

    @yungsters
    yungsters committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    bdfe9fe View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Add fast refresh test

    @rickhanlonii
    rickhanlonii committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    a2c9e7a View commit details
    Browse the repository at this point in the history

  2. Isolate !offscreenSubtreeWasHidden checks from flags checks

    @yungsters
    yungsters committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2101de0 View commit details
    Browse the repository at this point in the history

  3. Hoist __DEV__ check into @gate pragma

    @yungsters
    yungsters committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    1426f6d View commit details
    Browse the repository at this point in the history

  4. Check offscreenSubtreeIsHidden for attaching ref of Scope

    @yungsters
    yungsters committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    52c0e97 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Simplify test code (in preparation for adding more)

    @yungsters
    yungsters committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    a0685eb View commit details
    Browse the repository at this point in the history

  2. Add more test cases

    @yungsters
    yungsters committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    4036c91 View commit details
    Browse the repository at this point in the history

  3. Drop changes to ScopeComponent in commitMutationEffectsOnFiber

    @yungsters
    yungsters committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    1b7c7ee View commit details
    Browse the repository at this point in the history

  4. Fix missing Activity import in test case

    @yungsters
    yungsters committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    dc0c3a5 View commit details
    Browse the repository at this point in the history

  5. Fix ScopeComponent detach/attach behavior

    @yungsters
    yungsters committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    82bea69 View commit details
    Browse the repository at this point in the history