Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IngestExternalFileOptions update Java API to include several recently added option, in parity with C++ #12999

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

IngestExternalFileOptions update Java API to include several recently added option, in parity with C++ #12999

wants to merge 5 commits into from

Commits on Sep 18, 2024

  1. Java API - new external file ingest options 

    The C++ API IngestExternalFileOptions has options that are not present in the Java API. We have added these:
verify_checksums_before_ingest
verify_checksums_readahead_size
verify_file_checksum
fail_if_not_bottommost_level
    @alanpaxton
    alanpaxton committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    902925f View commit details
    Browse the repository at this point in the history

  2. Add ingest internal file option to link files 

    New option literally appeared when I rebased to PR previous updates. Add linkFiles option now.
    @alanpaxton
    alanpaxton committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    77388e7 View commit details
    Browse the repository at this point in the history

  3. Fix bad character in comment

    @alanpaxton
    alanpaxton committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    c8eb686 View commit details
    Browse the repository at this point in the history

  4. Review comments 

    Convert true/false to JNI_TRUE/JNI_FALSE correctly
    @alanpaxton
    alanpaxton committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    904f9d5 View commit details
    Browse the repository at this point in the history

  5. Remove unncessary JNIEXPORT and JNICALL

    @alanpaxton
    alanpaxton committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    2b8c3e7 View commit details
    Browse the repository at this point in the history