port: only override __PCLMUL__
on MSVC
#13006
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
We ran into issues when compiling RocksDB to
x86-64-v3
and other targets which haveavx
but notpclmul
. I believe the code is doing something different from what the comment is saying. This overrides__PCLMUL__
for all compilers, not just MSVC, which caused us to bring in intrinsics that weren't supported by the target.Is there a better way of solving this?