Fix orphaned files in SstFileManager #13015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D62590773 |
jowlyzhang
reviewed
Sep 14, 2024
There was a problem hiding this comment.
Thanks for adding this feature. This is a great addition. Do you mind also add a history entry in the unreleased_history directory.
cc @anand1976 this feels like a better solution to handle the leaking space from a SstFileManager's perspective issue. Compared to the alternative idea we discussed to implement similar things in DestroyDB. WDYT?
|
This pull request was exported from Phabricator. Differential Revision: D62590773 |
nickbrekhus
pushed a commit
to nickbrekhus/rocksdb
that referenced
this pull request
Sep 16, 2024
Summary: Pull Request resolved: facebook#13015 `Close()`ing a database now releases tracked files in `SstFileManager`. Previously this space would be leaked until the database was later reopened. Differential Revision: D62590773
nickbrekhus
force-pushed
the
export-D62590773
branch
from
8b99c90
to
4ea85b2
Compare
jowlyzhang
reviewed
Sep 16, 2024
|
There is a formatter inside of rocksdb repo, you can run |
|
This pull request was exported from Phabricator. Differential Revision: D62590773 |
nickbrekhus
pushed a commit
to nickbrekhus/rocksdb
that referenced
this pull request
Sep 17, 2024
Summary: Pull Request resolved: facebook#13015 `Close()`ing a database now releases tracked files in `SstFileManager`. Previously this space would be leaked until the database was later reopened. Differential Revision: D62590773
nickbrekhus
force-pushed
the
export-D62590773
branch
from
4ea85b2
to
54f9c5a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62590773 |
nickbrekhus
pushed a commit
to nickbrekhus/rocksdb
that referenced
this pull request
Sep 17, 2024
Summary: Pull Request resolved: facebook#13015 `Close()`ing a database now releases tracked files in `SstFileManager`. Previously this space would be leaked until the database was later reopened. Differential Revision: D62590773
nickbrekhus
force-pushed
the
export-D62590773
branch
from
54f9c5a
to
ee42864
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62590773 |
nickbrekhus
pushed a commit
to nickbrekhus/rocksdb
that referenced
this pull request
Sep 17, 2024
Summary: Pull Request resolved: facebook#13015 `Close()`ing a database now releases tracked files in `SstFileManager`. Previously this space would be leaked until the database was later reopened. Differential Revision: D62590773
nickbrekhus
force-pushed
the
export-D62590773
branch
from
ee42864
to
8040b2c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62590773 |
nickbrekhus
pushed a commit
to nickbrekhus/rocksdb
that referenced
this pull request
Sep 18, 2024
Summary: Pull Request resolved: facebook#13015 `Close()`ing a database now releases tracked files in `SstFileManager`. Previously this space would be leaked until the database was later reopened. Differential Revision: D62590773
nickbrekhus
force-pushed
the
export-D62590773
branch
from
8040b2c
to
7a10d08
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62590773 |
nickbrekhus
pushed a commit
to nickbrekhus/rocksdb
that referenced
this pull request
Sep 18, 2024
Summary: Pull Request resolved: facebook#13015 `Close()`ing a database now releases tracked files in `SstFileManager`. Previously this space would be leaked until the database was later reopened. Differential Revision: D62590773
nickbrekhus
force-pushed
the
export-D62590773
branch
from
7a10d08
to
9875575
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62590773 |
nickbrekhus
pushed a commit
to nickbrekhus/rocksdb
that referenced
this pull request
Sep 18, 2024
Summary: Pull Request resolved: facebook#13015 `Close()`ing a database now releases tracked files in `SstFileManager`. Previously this space would be leaked until the database was later reopened. Differential Revision: D62590773
nickbrekhus
force-pushed
the
export-D62590773
branch
from
9875575
to
9b5d8a2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62590773 |
nickbrekhus
pushed a commit
to nickbrekhus/rocksdb
that referenced
this pull request
Sep 18, 2024
Summary: Pull Request resolved: facebook#13015 `Close()`ing a database now releases tracked files in `SstFileManager`. Previously this space would be leaked until the database was later reopened. Differential Revision: D62590773
nickbrekhus
force-pushed
the
export-D62590773
branch
from
9b5d8a2
to
2daccfb
Compare
jowlyzhang
approved these changes
Sep 18, 2024
|
This pull request was exported from Phabricator. Differential Revision: D62590773 |
nickbrekhus
pushed a commit
to nickbrekhus/rocksdb
that referenced
this pull request
Sep 18, 2024
Summary: Pull Request resolved: facebook#13015 `Close()`ing a database now releases tracked files in `SstFileManager`. Previously this space would be leaked until the database was later reopened. Reviewed By: jowlyzhang Differential Revision: D62590773
nickbrekhus
force-pushed
the
export-D62590773
branch
from
2daccfb
to
ca008a6
Compare
Summary: Pull Request resolved: facebook#13015 `Close()`ing a database now releases tracked files in `SstFileManager`. Previously this space would be leaked until the database was later reopened. Reviewed By: jowlyzhang Differential Revision: D62590773
|
This pull request was exported from Phabricator. Differential Revision: D62590773 |
nickbrekhus
force-pushed
the
export-D62590773
branch
from
ca008a6
to
a0ec4c0
Compare
|
This pull request has been merged in 0611eb5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Close()ing a database now releases tracked files inSstFileManager. Previously this space would be leaked until the database was later reopened.Differential Revision: D62590773