Support bitmap with opacity animation on Android (#135)

facebookarchive · Jun 15, 2017 · d6ae643 · d6ae643
1 parent 6acda2f
commit d6ae643
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/android/keyframes/src/main/java/com/facebook/keyframes/KeyframesDrawable.java b/android/keyframes/src/main/java/com/facebook/keyframes/KeyframesDrawable.java
@@ -189,18 +189,23 @@ public void draw(Canvas canvas) {
         continue;
       }
 
+      // We need paint for drawing (opacity animated) bitmaps and paths
+      mDrawingPaint.setShader(null);
+      mDrawingPaint.setAlpha(featureState.getAlpha());
+
+      // Drawing bitmap
       final Bitmap backedImage = featureState.getBackedImageBitmap();
       final Matrix uniqueFeatureMatrix = featureState.getUniqueFeatureMatrix();
       if (backedImage != null && uniqueFeatureMatrix != null) {
         // This block is for the experimental bitmap supporting
         canvas.save();
         canvas.concat(mScaleMatrix);
-        canvas.drawBitmap(backedImage, uniqueFeatureMatrix, null);
-
+        canvas.drawBitmap(backedImage, uniqueFeatureMatrix, mDrawingPaint);
         canvas.restore();
         continue;
       }
 
+      // Drawing path
       pathToDraw = featureState.getCurrentPathForDrawing();
       if (pathToDraw == null || pathToDraw.isEmpty()) {
         continue;
@@ -209,7 +214,6 @@ public void draw(Canvas canvas) {
         canvas.save();
         applyScaleAndClipCanvas(canvas, featureState.getCurrentMaskPath(), Region.Op.INTERSECT);
       }
-      mDrawingPaint.setShader(null);
       mDrawingPaint.setStrokeCap(featureState.getStrokeLineCap());
       if (featureState.getFillColor() != Color.TRANSPARENT) {
         mDrawingPaint.setStyle(Paint.Style.FILL);
@@ -224,7 +228,6 @@ public void draw(Canvas canvas) {
       }
       if (featureState.getStrokeColor() != Color.TRANSPARENT && featureState.getStrokeWidth() > 0) {
         mDrawingPaint.setColor(featureState.getStrokeColor());
-        mDrawingPaint.setAlpha(featureState.getAlpha());
         mDrawingPaint.setStyle(Paint.Style.STROKE);
         mDrawingPaint.setStrokeWidth(
                 featureState.getStrokeWidth() * mScale * mScaleFromCenter * mScaleFromEnd);
@@ -484,6 +487,7 @@ public void setupFeatureStateForProgress(float frameProgress) {
       if (layerTransformMatrix != null && !layerTransformMatrix.isIdentity()) {
         mFeatureMatrix.postConcat(layerTransformMatrix);
       }
+      mFeature.setOpacity(mOpacity, frameProgress);
       KeyFramedPath path = mFeature.getPath();
       if (hasCustomDrawable() || path == null) {
         return; // skip all the path stuff
@@ -494,8 +498,8 @@ public void setupFeatureStateForProgress(float frameProgress) {
 
       mFeature.setStrokeWidth(mStrokeWidth, frameProgress);
       mFeature.setStrokeColor(mStrokeColor, frameProgress);
+      mFeature.setFillColor(mFillColor, frameProgress);
       mStrokeWidth.adjustScale(extractScaleFromMatrix(mFeatureMatrix));
-      mFeature.setOpacity(mOpacity, frameProgress);
       if (mFeature.getEffect() != null) {
         prepareShadersForFeature(mFeature);
       }