This repository was archived by the owner on Apr 2, 2021. It is now read-only.
Use locale insensitive toUpperCase and toLowerCase #729
Open
kyo504 wants to merge 1 commit intofacebookarchive:masterfrom
Open
Use locale insensitive toUpperCase and toLowerCase #729kyo504 wants to merge 1 commit intofacebookarchive:masterfrom
kyo504 wants to merge 1 commit intofacebookarchive:masterfrom
Conversation
|
Maybe better to not use a case transformation for such keys at all and instead replace it with a more robust transformation logic? |
Author
|
@mifi yeah, that would be another way to solve this problem. But I don't know the history of current implementation and what you mentioned would cause backward compatibility issue(I think this is not as important as all the people should bump major version). |
Contributor
|
I agree with @mifi, can we use a switch statement to return the proper enum value instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # #728
Test Plan:
Before this PR, if you run following example,
you could see the following error on Android Debug Console.
And this leads crash on release mode. I've tested that app works fine after this pr.