Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include cstdint for int*_t in profiler #1003

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chengscott
Copy link
Contributor

The conv2d profiler can be built well with gcc-12.
But, when switching to gcc-13, compilation failed with error listed below.
This error may caused by reduced usage of cstdint header (https://gcc.gnu.org/gcc-13/porting_to.html)
This PR fixes the error by adding the cstdint header.

2024-05-01 18:20:30,972 INFO <aitemplate.backend.builder> make stderr:

conv2d_bias_relu/temp_bfe88629c48a2a08697feb310392b6d3f905c152.cu(24): error: identifier "uint8_t" is undefined
    uint8_t*,
    ^

conv2d_bias_relu/temp_bfe88629c48a2a08697feb310392b6d3f905c152.cu(46): error: identifier "uint8_t" is undefined
    uint8_t*,
    ^

conv2d_bias_relu/temp_bfe88629c48a2a08697feb310392b6d3f905c152.cu(68): error: identifier "uint8_t" is undefined
    uint8_t*,
    ^

conv2d_bias_relu/temp_bfe88629c48a2a08697feb310392b6d3f905c152.cu(90): error: identifier "uint8_t" is undefined
    uint8_t*,
    ^

conv2d_bias_relu/temp_bfe88629c48a2a08697feb310392b6d3f905c152.cu(112): error: identifier "uint8_t" is undefined
    uint8_t*,
    ^

conv2d_bias_relu/temp_bfe88629c48a2a08697feb310392b6d3f905c152.cu(134): error: identifier "uint8_t" is undefined
    uint8_t*,
    ^

conv2d_bias_relu/temp_bfe88629c48a2a08697feb310392b6d3f905c152.cu(156): error: identifier "uint8_t" is undefined
    uint8_t*,
    ^

conv2d_bias_relu/temp_bfe88629c48a2a08697feb310392b6d3f905c152.cu(178): error: identifier "uint8_t" is undefined
    uint8_t*,
...

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 1, 2024
@ColinPeppler
Copy link
Contributor

Hi @chengscott,

can we also explicitly mark the namespace int*_t is coming from? maybe using std::int8_t;?

@chengscott
Copy link
Contributor Author

Sure, updated.

@facebook-github-bot
Copy link
Contributor

@chenyang78 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@chenyang78
Copy link
Contributor

@chengscott Thank you for sending the patch! It caused some issue in our internal CI. Will get you back later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants