add ability to limit the size of the send queue buffer. #561
Conversation
By default _outputBuffer size is not limited and can grow over to the point that iOS decides to kill the app. By setting maxTxQueueSize it's now possible to ensure that the _outputBuffer size will not consume too much memory. This is done by blocking the send: methods until _outputBuffer size decreases (once data has actually been sent over the websocket connedtion).
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
By default _outputBuffer size is not limited and can grow over to the point that iOS decides to kill the app.
By setting maxTxQueueSize it's now possible to ensure that the _outputBuffer size will not consume too much memory.
This is done by blocking the send: methods until _outputBuffer size decreases (once data has actually been sent over the websocket connection).
We were experiencing app termination while trying to upload user videos to our server using websocket, because of this.
I think this is what cased some people to complain in #121
I've added a sample app to test this in my fork: r0ro@728a154