Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SRRunLoopThread.m #659

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Wxm510846302
Copy link

修复iOS16 优先级反转警告
fix iOS 16 Xcode14 Thread Performance Checker: Thread running at QOS_CLASS_USER_INTERACTIVE waiting on a lower QoS thread running at QOS_CLASS_DEFAULT

修复iOS16 优先级反转警告
@facebook-github-bot
Copy link
Contributor

Hi @Wxm510846302!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@Wxm510846302
Copy link
Author

Hello, I have completed the contributor license agreement

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

OSSpinLock 被替换 os_unfair_lock
@molenick
Copy link

molenick commented Aug 9, 2023

Thanks for the pr, this is great. Is there anything blocking this from being merged?

@jacquesdev
Copy link

@Wxm510846302 - just curious - not sure if you saw this #661 (comment). If that does indeed fix the issue, just wondering how it compares to your solution? Since this is a one liner, just wondering if it's better or not?

@jacquesdev
Copy link

In fact having read a bit more about this, it seems that SocketRocket 0.70 already implemented this, 7240f2d, but I still wonder if it's the correct fix. If it is, then maybe this PR is no longer required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants