Add new expect action #501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructs **Changed:** - Refactored `expect.yaml` to remove `type` fields from steps. - Updated `basicstep.go` and `expectstep.go` to remove `type` field from step structs and initialization. - Modified `step.go` to dynamically determine step types without `type` field. - Enhanced `expectstep_test.go` with additional test cases for ExpectStep. **Added:** - Introduced environment and output fields to ExpectStep struct. - Added error handling for missing responses in ExpectStep validation. **Removed:** - Removed redundant log messages from `step.go`.
… attributes. **Added:** - Detailed comments for ExpectStep attributes in `expectstep.go` - Detailed comments for Response attributes in `expectstep.go` - Detailed comments for all ExpectStep methods in `expectstep.go` - Check for ambiguous types in ParseAction method of `step.go` - Additional fields (File, TTP, EditFile) in ParseAction method of `step.go` **Changed:** - Renamed error messages in `expectstep.go` to lowercase for consistency - Updated copyright year in `step.go` - Refactored comments to adhere to GoDoc standards in `expectstep.go`
**Added:** - Directory change handling in ExpectStep `Execute` method with defer function - New test case for ExpectStep with directory change verification - Cleanup step execution in test cases to verify script removal **Changed:** - Refactored `createTestScript` to accept script content as a parameter - Updated test cases to use dynamic script content - Adjusted ExpectStep validation to remove redundant comments **Removed:** - Removed license header from `expectstep_test.go` for simplicity
l50
requested review from
d3sch41n,
cedowens,
d0n601 and
CrimsonK1ng
as code owners
TTPForge-bot
added
area/pre-commit
|
@l50 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
the go-expect library.
Changed:
libraries, and updated existing dependencies.
Removed:
.pre-commit-config.yaml.