Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused exception parameter from gloo/rendezvous/context.cc #378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove unused exception parameter from gloo/rendezvous/context.cc #378

wants to merge 1 commit into from

Commits on Jan 5, 2024

  1. Remove unused exception parameter from gloo/rendezvous/context.cc 

    Summary:
`-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it.

This:
```
try {
    ...
} catch (exception& e) {
    // no use of e
}
```
should instead be written as
```
} catch (exception&) {
```

If the code compiles, this is safe to land.

Reviewed By: palmje

Differential Revision: D51785901
    @r-barnes @facebook-github-bot
    r-barnes authored and facebook-github-bot committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    0ec8d3c View commit details
    Browse the repository at this point in the history