Add getFileRawDataSize Test Utilities #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61050482 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 20, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Differential Revision: D61050482
|
This pull request was exported from Phabricator. Differential Revision: D61050482 |
phoenixawe
force-pushed
the
export-D61050482
branch
from
a2c5d1c
to
ec50eb1
Compare
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 20, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Differential Revision: D61050482
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 20, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Differential Revision: D61050482
|
This pull request was exported from Phabricator. Differential Revision: D61050482 |
phoenixawe
force-pushed
the
export-D61050482
branch
from
ec50eb1
to
0fc9a1a
Compare
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 20, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Differential Revision: D61050482
|
This pull request was exported from Phabricator. Differential Revision: D61050482 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 20, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Differential Revision: D61050482
phoenixawe
force-pushed
the
export-D61050482
branch
from
0fc9a1a
to
dfc7e13
Compare
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 21, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Differential Revision: D61050482
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 22, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Differential Revision: D61050482
|
This pull request was exported from Phabricator. Differential Revision: D61050482 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 22, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Differential Revision: D61050482
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 22, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Differential Revision: D61050482
phoenixawe
force-pushed
the
export-D61050482
branch
from
dfc7e13
to
308ab8b
Compare
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 22, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Differential Revision: D61050482
|
This pull request was exported from Phabricator. Differential Revision: D61050482 |
phoenixawe
force-pushed
the
export-D61050482
branch
from
308ab8b
to
00ca9f6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61050482 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 24, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Differential Revision: D61050482
phoenixawe
force-pushed
the
export-D61050482
branch
from
00ca9f6
to
c8045b3
Compare
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 24, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Differential Revision: D61050482
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 27, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Differential Revision: D61050482
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 27, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Differential Revision: D61050482
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 27, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Differential Revision: D61050482
phoenixawe
force-pushed
the
export-D61050482
branch
from
9796377
to
38dec5d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61050482 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 4, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Differential Revision: D61050482
phoenixawe
force-pushed
the
export-D61050482
branch
from
38dec5d
to
1b7b4fe
Compare
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 4, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Differential Revision: D61050482
|
This pull request was exported from Phabricator. Differential Revision: D61050482 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 4, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Reviewed By: sdruzkin Differential Revision: D61050482
phoenixawe
force-pushed
the
export-D61050482
branch
from
1b7b4fe
to
47646b9
Compare
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 4, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Reviewed By: sdruzkin Differential Revision: D61050482
|
This pull request was exported from Phabricator. Differential Revision: D61050482 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 4, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Reviewed By: sdruzkin Differential Revision: D61050482
phoenixawe
force-pushed
the
export-D61050482
branch
from
47646b9
to
73ffabc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61050482 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 19, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Reviewed By: sdruzkin, helfman Differential Revision: D61050482
phoenixawe
force-pushed
the
export-D61050482
branch
from
73ffabc
to
bd81410
Compare
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 19, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Differential Revision: D61050482 Reviewed By: sdruzkin, helfman
|
This pull request was exported from Phabricator. Differential Revision: D61050482 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 19, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Reviewed By: sdruzkin, helfman Differential Revision: D61050482
phoenixawe
force-pushed
the
export-D61050482
branch
from
bd81410
to
bbf1351
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61050482 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 19, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Reviewed By: sdruzkin, helfman Differential Revision: D61050482
phoenixawe
force-pushed
the
export-D61050482
branch
from
bbf1351
to
d433ecb
Compare
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawDataSize` function. # Context This will be used by nimble_dump later on. RawDataSize is for streams and encodings, so this captures the raw data size *after* some optimizations such as deduping are applied, but *before* compression and serde. Reviewed By: sdruzkin, helfman Differential Revision: D61050482
|
This pull request was exported from Phabricator. Differential Revision: D61050482 |
phoenixawe
force-pushed
the
export-D61050482
branch
from
d433ecb
to
7a84856
Compare
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 19, 2024
Summary: Pull Request resolved: facebookincubator#73 # Changes Adding functions to the TestUtils.h in tests folders of both `encodings` and `velox` which allows us to calculate the raw data size of files by reading. - Note the special handling for Nullable encoding types and String data types in the `getRawChunkSize` function. # Context This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing. This change will also be used by nimble_dump later on (to be implemented in a later diff). Differential Revision: D61050482 Reviewed By: sdruzkin, helfman
|
This pull request has been merged in eda098a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changes
Adding functions to the TestUtils.h in tests folders of both
encodingsandveloxwhich allows us to calculate the raw data size of files by reading.getRawChunkSizefunction.Context
This is necessary to check the correctness of the raw data size stat added in the following diff, which calculates the size when writing.
This change will also be used by nimble_dump later on (to be implemented in a later diff).
Differential Revision: D61050482