Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gpu user annotation breakdown #217

Closed
wants to merge 4 commits into from
Closed

Update gpu user annotation breakdown #217

wants to merge 4 commits into from

Conversation

briancoutinho
Copy link
Contributor

@briancoutinho briancoutinho commented Feb 10, 2025 •
edited
Loading

Summay

Fixes #180. Some additional improvements to past change #209

  1. Add use_gpu_time= option that allows the feature to aggregate both CPU user annotations and GPU user annotations.
  2. Visualization and API were improved as some options are not needed. For example kernel_type does not make sense since user annotation names are user provided.
  3. Added unit tests.

Before submitting

  • [y] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • [y] Did you write any new necessary tests?
    • N/A
  • Did you make sure to update the docs?
    • [y] N/A
  • Did you update the changelog?
    • [y] N/A

Testplan:

Run feature

Screenshot 2025-02-10 at 4 23 44 PM
Screenshot 2025-02-10 at 4 27 23 PM

unit test

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 10, 2025
@briancoutinho briancoutinho changed the title 0209 gpu user breakdown Update gpu user annotation breakdown Feb 10, 2025
@briancoutinho briancoutinho marked this pull request as ready for review February 11, 2025 00:27
@facebook-github-bot
Copy link
Contributor

@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@briancoutinho merged this pull request in 267ea8c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengxizhou fengxizhou Awaiting requested review from fengxizhou

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kernel Breakdown by Annotation Range
2 participants
@briancoutinho @facebook-github-bot