Draft
Conversation
facebook-github-bot
added
the
CLA Signed
chrisklaiber
reviewed
Sep 6, 2024
Contributor
chrisklaiber
left a comment
chrisklaiber
left a comment
There was a problem hiding this comment.
Good idea to get up a draft PR!
My guidance here is that, when working with a "System", it composes multiple of the streams. You might have noticed here that wrapping each stream with a system doesn't add much value. Instead, the place for a system would be in the example, to replace the main functions that compose the streams. E.g., a "RemoteInferenceSystem" or a "LocalInferenceSystem". The systems would contain everything except for input and output, as we'd leave that up to the client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for iftk-friendly system and channel interface wrappers for iftk's helper streamer functions.
Rationale
The PR's main rationale is making our helper functions have support for iftk's already implemented system and channel interfaces for modularity purposes.
Testing
All of the helper streaming functions have been tested under
/tests/helpers. The system-channel interfaces are subclass wrappers of these tested functions.