#6 Implement metric pipeline to analyze model performance#32
Merged
botirk38 merged 13 commits intofacebookresearch:mainfrom Sep 3, 2024
botirk38:feature/metric-analyzer
Merged
#6 Implement metric pipeline to analyze model performance#32botirk38 merged 13 commits intofacebookresearch:mainfrom botirk38:feature/metric-analyzer
botirk38 merged 13 commits intofacebookresearch:mainfrom
botirk38:feature/metric-analyzer
Conversation
artemru
reviewed
Jul 30, 2024
…iple metrics to be passed
antoine-tran
approved these changes
Aug 14, 2024
artemru
added a commit
that referenced
this pull request
Sep 6, 2024
artemru
added a commit
that referenced
this pull request
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
We need to implement this feature to analyze the performance of our pipeline according to specified metrics. The primary use cases are:
This implementation will allow us to:
How?
Key technical decisions made in this implementation:
MetricPipelineConfigclass extendingPipelineConfigto encapsulate metric-specific configuration.MetricAnalyzerPipelineclass that inherits from the basePipelineclass.evaluatelibrary to load and compute metrics.Key components:
MetricOverwrites: Allows for easy overriding of metric-specific configurations.compute_metric: Calculates the metric score for a given set of original and reconstructed data.process_batch: Applies the metric computation to each specified column in a batch.__call__: Processes the entire dataset using the configured metric.Work in Progress (WIP) parts:
process_batchmethod.resultsattribute inMetricAnalyzerPipelineis initialized but not used in the current implementation.Test plan
To test these changes, we will:
MetricAnalyzerPipeline.