-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#6 Implement metric pipeline to analyze model performance #32
Merged
botirk38
merged 13 commits into
facebookresearch:main
from
botirk38:feature/metric-analyzer
Sep 3, 2024
Merged
#6 Implement metric pipeline to analyze model performance #32
botirk38
merged 13 commits into
facebookresearch:main
from
botirk38:feature/metric-analyzer
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jul 19, 2024
artemru
reviewed
Jul 30, 2024
…iple metrics to be passed
botirk38
changed the title
Implement metric pipeline to analyze model performance
#5 Implement metric pipeline to analyze model performance
Aug 2, 2024
botirk38
changed the title
#5 Implement metric pipeline to analyze model performance
#6 Implement metric pipeline to analyze model performance
Aug 12, 2024
antoine-tran
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me. I think some code needs to be improved but once the comments are addressed (and make linter happy ofc), we can land this
artemru
added a commit
that referenced
this pull request
Sep 6, 2024
artemru
added a commit
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We need to implement this feature to analyze the performance of our pipeline according to specified metrics. The primary use cases are:
This implementation will allow us to:
How?
Key technical decisions made in this implementation:
MetricPipelineConfig
class extendingPipelineConfig
to encapsulate metric-specific configuration.MetricAnalyzerPipeline
class that inherits from the basePipeline
class.evaluate
library to load and compute metrics.Key components:
MetricOverwrites
: Allows for easy overriding of metric-specific configurations.compute_metric
: Calculates the metric score for a given set of original and reconstructed data.process_batch
: Applies the metric computation to each specified column in a batch.__call__
: Processes the entire dataset using the configured metric.Work in Progress (WIP) parts:
process_batch
method.results
attribute inMetricAnalyzerPipeline
is initialized but not used in the current implementation.Test plan
To test these changes, we will:
MetricAnalyzerPipeline
.