add library_name parameter to hf_hub_download for better model tracking on the Hub.
#325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
adefossez
suggested changes
Oct 23, 2023
audiocraft/models/loaders.py
Outdated
| @@ -60,7 +60,7 @@ def _get_state_dict( | |||
| else: | |||
| assert filename is not None, "filename needs to be defined if using HF checkpoints" | |||
|
|
|||
| file = hf_hub_download(repo_id=file_or_url_or_id, filename=filename, cache_dir=cache_dir) | |||
| file = hf_hub_download(repo_id=file_or_url_or_id, filename=filename, cache_dir=cache_dir, library_name="audiocraft", library_version="1.0.0") | |||
There was a problem hiding this comment.
you can get the actual version from audiocraft.__version__ :)
|
I'm directly adding this into #345 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there - hf_hub_download in the huggingface_hub package allows for better tracking for the model checkpoint usage via
library_nameandlibrary_version.This change would not impact any existing downloads, it'll only result in extra information that'll help us get more detailed stats.