-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UE #1
Open
una-dinosauria
wants to merge
7
commits into
main
Choose a base branch
from
julieta/ue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
UE #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
una-dinosauria
commented
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an overall overview of how this code is used?
Ie, what are the inputs, outputs, what should run first, etc?
models/headset_encoders/universal.py
Outdated
Comment on lines
121
to
124
if __name__ == "__main__": | ||
num_conds = 1 | ||
hmc_cond_imgs = torch.rand((2, num_views, num_conds, in_chans, 400, 400), dtype=torch.float32) | ||
expression_encoder = UniversalEncoder( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this main?
jerrybai1995
pushed a commit
that referenced
this pull request
Jun 14, 2024
* replace internal extensions with oss ones * instructions on how to compile extensions * test only with oss extensions * completely remove old kernels * remove oss sufixes * put templates' channels last in the decoders themselves Co-authored-by: julietamartinez <julietamartinez@meta.com>
jerrybai1995
pushed a commit
that referenced
this pull request
Jun 14, 2024
…ing_file_exists Adding Contributing file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Universal encoder written by @leochli and @jerrybai1995. Reposted by Julieta after resetting the repo.