Skip to content

Add option to disable EOS appending in preprocessing (#5615) #5616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
surprisedPikachu007 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add option to disable EOS appending in preprocessing (#5615) #5616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions fairseq/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,9 @@ def add_preprocess_args(parser):
help="number of parallel workers")
group.add_argument("--dict-only", action='store_true',
help="if true, only builds a dictionary and then exits")
group.add_argument("--no-eos-append", action="store_false",
dest="append_eos", default=True,
help="Do not append EOS to the end of each document")
# fmt: on
return parser

Expand Down
2 changes: 1 addition & 1 deletion fairseq_cli/preprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def _make_binary_dataset(

binarizer = VocabularyDatasetBinarizer(
vocab,
append_eos=True,
append_eos=args.append_eos,
)

input_file = "{}{}".format(input_prefix, ("." + lang) if lang is not None else "")
Expand Down