upgrade to python 3.12 and move to pyinstaller #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace PyOxidizer with PyInstaller for building standalone binaries - Add gcm.spec and health_checks.spec for PyInstaller configuration - Update Makefile to use PyInstaller build commands - Update debian/rules for new PyInstaller output paths - Update GitHub workflows to remove Rust dependency - Update pyproject.toml to use pyinstaller instead of pyoxidizer - Update build_deb.sh to use pyinstaller - Update .gitignore to allow .spec files - Update CONTRIBUTING.md documentation PyInstaller provides better Python 3.12 support and doesn't require Rust toolchain, simplifying the build process. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Replace tomli imports with tomllib (standard library in Python 3.12+) - Remove tomli dependency from pyproject.toml - Update PyInstaller spec files to remove tomli workarounds - Regenerate dev-requirements.txt with pyinstaller instead of pyoxidizer This fixes PyInstaller build issues with mypyc-compiled tomli modules by using the standard library tomllib instead.
- Move tomllib import to standard library section - Fix import ordering in all files that use tomllib - Ensures compliance with isort/usort formatting rules
- Use proper shell if/then instead of || && chain - Use find to copy everything except the executable when no _internal dir - Prevents 'rm: cannot remove directory' error
luccabb
changed the title
PyInstaller is already in dev-requirements.txt, no need to install separately.
- Include all exporter plugins (do_nothing, stdout, file, otel, graph_api) - Fixes sink validation errors in health_checks - Ensures exporters.registry can discover all sink plugins
This is a proper Python 3.12 migration - use the stdlib tomllib module directly instead of maintaining compatibility with the old tomli package name. Changes: - import tomllib (not import tomllib as tomli) - tomllib.load() and tomllib.TOMLDecodeError everywhere 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan