Add sprio collector for job priority logging #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yash0270
requested review from
calebho,
giongto35,
jj10306 and
luccabb
as code owners
Summary: Adds a new `sprio` collector to log Slurm job priority factors to GCM, enabling FAIR Passport to display priority breakdowns for users across clusters. ## What's New | Component | Description | |-----------|-------------| | CLI command | `gcm sprio --sink stdout --once` | | Schema | `SprioRow` dataclass with format code metadata | | Output | 14 priority fields (JOBID, PRIORITY, FAIRSHARE, etc.) | | Collection | Every 2 minutes via `collection_unixtime` snapshots | | Destination | Scuba table `fair_sprio` via OTEL sink | ## Key Design Decisions - **Schema-driven format**: Header and format spec are auto-generated from `SprioRow` field definitions, guaranteeing they always match - **Custom headers**: SLURM's sprio outputs incorrect headers for some codes (`%A` → "AGE" instead of "ASSOC"), so we define our own - **Consistent ordering**: Jobs sorted by partition and priority descending (`--sort=r,-y`) - **Type-safe fields**: Numeric fields (JOBID, PRIORITY, SITE, AGE, FAIRSHARE, JOBSIZE, PARTITION_PRIO, NICE) are parsed as float; identifiers remain strings - **No TRES field**: Removed TRES since it's rarely used and complicates parsing ## Related - Pattern: follows `sacctmgr_user` (D77916380) - Helm config: D92180317 Reviewed By: luccabb Differential Revision: D92178369
Yash0270
force-pushed
the
export-D92178369
branch
from
b2878f6 to
33a78d1
Compare
luccabb
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a new sprio collector to log Slurm job priority information to GCM.
This enables the FAIR Passport tool to display job priority factors for
users across clusters.
The implementation follows the same pattern as sacctmgr_user (T225759676, D77916380):
gcm sprio --sink stdout --onceACCOUNT, PRIORITY, SITE, AGE, ASSOC, FAIRSHARE, JOBSIZE, PARTITION_PRIO,
QOSNAME, QOS, NICE, TRES)
Data will be logged to Scuba table
fair_spriovia OTEL sink.Helm configuration: D92180317
Differential Revision: D92178369